[IMPROVEMENT] Tap on avatar/username/channel to show info#1097
Merged
diegolmello merged 8 commits intoRocketChat:developfrom Aug 22, 2019
Merged
[IMPROVEMENT] Tap on avatar/username/channel to show info#1097diegolmello merged 8 commits intoRocketChat:developfrom
diegolmello merged 8 commits intoRocketChat:developfrom
Conversation
pranavpandey1998official
changed the title
pranavpandey1998official
changed the title
This was referenced Aug 2, 2019
diegolmello
changed the title
diegolmello
requested changes
Aug 7, 2019
Member
diegolmello
left a comment
diegolmello
left a comment
There was a problem hiding this comment.
REALLY AWESOME!
Can you add e2e tests to ensure nothing will break after a few releases?
Thanks!
diegolmello
approved these changes
Aug 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/ReactNative
Closes #729
Closes #966