Skip to content

[NEW] Custom OAuth#1093

Merged
diegolmello merged 5 commits intoRocketChat:developfrom
jbuechele:custom-oauth-support
Aug 7, 2019
Merged

[NEW] Custom OAuth#1093
diegolmello merged 5 commits intoRocketChat:developfrom
jbuechele:custom-oauth-support

Conversation

@jbuechele
Copy link
Copy Markdown
Contributor

@jbuechele jbuechele commented Jul 31, 2019

@RocketChat/ReactNative

Closes #1018

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 31, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jbuechele jbuechele changed the title added oauth custom support [Feature] added oauth custom support Jul 31, 2019
@diegolmello
Copy link
Copy Markdown
Member

diegolmello commented Jul 31, 2019

@jbuechele Thanks for your work!
Can you fix lint?
I'll review your PR right after.
Cheers.

@jbuechele
Copy link
Copy Markdown
Contributor Author

jbuechele commented Aug 1, 2019

The lint errors were fixed.

@diegolmello diegolmello requested a review from philipbrito August 1, 2019 16:41
@philipbrito philipbrito changed the title [Feature] added oauth custom support [NEW] Custom OAuth Aug 2, 2019
philipbrito
philipbrito approved these changes Aug 4, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@philipbrito philipbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality is working fine. As further improvement we can render the custom OAuth button by getting its style from the backend.

Yours:

Screen Shot 2019-08-04 at 13 26 28

Ours:

Screen Shot 2019-08-04 at 13 33 46

Server:

Screen Shot 2019-08-04 at 13 36 34

Thank you!

@rasos
Copy link
Copy Markdown

rasos commented Aug 6, 2019

Very useful, looking forward to have this PR in the next release.

@jbuechele
Copy link
Copy Markdown
Contributor Author

jbuechele commented Aug 6, 2019

OAuth

Should I change it or have you already changed it? But we could also just render the icon of oauth or openid connect? Then the buttons would look consistent.

@philipbrito philipbrito mentioned this pull request Aug 6, 2019
Merged
philipbrito
philipbrito suggested changes Aug 6, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@philipbrito philipbrito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, we have a bug!

Try connection with a different server, then go to the server which supports custom OAuth authentication -> the login "method" list from the first server is being displayed on the second one.

@jbuechele
Copy link
Copy Markdown
Contributor Author

jbuechele commented Aug 7, 2019

Wait, we have a bug!

Try connection with a different server, then go to the server which supports custom OAuth authentication -> the login "method" list from the first server is being displayed on the second one.

The bug is fixed. The Reducer has merged the old login services with the new ones

@diegolmello
Copy link
Copy Markdown
Member

diegolmello commented Aug 7, 2019

@jbuechele Great job! I'll review/merge it today! :)

diegolmello
diegolmello approved these changes Aug 7, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit 6a3523d into RocketChat:develop Aug 7, 2019
@diegolmello
Copy link
Copy Markdown
Member

diegolmello commented Aug 7, 2019

Merged. Thanks, @jbuechele! 👊

@yeoldegrove
Copy link
Copy Markdown

yeoldegrove commented Aug 9, 2019

@diegolmello Will you bump the version, so that I can download this from google play?

@diegolmello
Copy link
Copy Markdown
Member

diegolmello commented Aug 9, 2019

@yeoldegrove Yes, I'm fixing a few bugs on RN update and I'll release this soon.
First I have to review and merge #1108 and #1116 also.

djorkaeffalexandre pushed a commit that referenced this pull request Aug 9, 2019
@jbuechele @diegolmello
[NEW] Custom OAuth (#1093)
8169981
@lorek123 lorek123 mentioned this pull request Sep 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegolmello diegolmello diegolmello approved these changes

+1 more reviewer

@philipbrito philipbrito philipbrito requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🎉 feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Custom OAuth

6 participants

@jbuechele @CLAassistant @diegolmello @rasos @yeoldegrove @philipbrito