Skip to content

chore: update Electron from 40.0.0 to 40.8.5#3285

Merged
jeanfbrito merged 1 commit intodevfrom
chore/electron-40.8.5
Apr 1, 2026
Merged

chore: update Electron from 40.0.0 to 40.8.5#3285
jeanfbrito merged 1 commit intodevfrom
chore/electron-40.8.5

Conversation

@jeanfbrito
Copy link
Copy Markdown
Member

@jeanfbrito jeanfbrito commented Apr 1, 2026 •
edited by coderabbitai bot
Loading

Summary

  • Updates Electron from 40.0.0 to 40.8.5 (latest in the 40.x series)
  • Chromium updated from 144.0.7559.68 to 144.0.7559.236
  • Node.js updated from 24.11.0 to 24.14.0
  • No breaking changes — all 40.x releases are backwards-compatible patch/minor updates

Notable fixes included

  • Fixed clipboard.readImage() crash with malformed image data
  • Fixed Windows notification icons failing due to invalid filename characters
  • Fixed macOS safeStorage keychain migration issues
  • Fixed Windows shutdown crash with hidden titlebar
  • Fixed macOS frameless window resize in MAS builds
  • Fixed Linux menu bar hiding after setFullScreen(false)
  • Fixed desktopCapturer CoreAudio Tap API for macOS audio capture
  • Fixed offscreen rendering screen info and media queries

Test plan

  • TypeScript compilation passes (tsc --noEmit)
  • ESLint passes (no errors)
  • All 213 tests pass across 17 suites
  • Manual smoke test on macOS
  • CI build verification

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated Electron runtime dependency to version 40.8.5, incorporating bug fixes, stability improvements, and security updates to the application's build environment.

@jeanfbrito
chore: update Electron from 40.0.0 to 40.8.5
65086a2 
Picks up Chromium 144.0.7559.236 and Node.js 24.14.0 with numerous
bug fixes including clipboard crash, Windows notification icons,
macOS safeStorage keychain migration, and desktopCapturer CoreAudio
Tap API support. No breaking changes within the 40.x series.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c95a7dfa-1d72-43a7-a64c-300bcb280045

📥 Commits

Reviewing files that changed from the base of the PR and between f5be646 and 65086a2.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: check (windows-latest)
  • GitHub Check: check (ubuntu-latest)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings 
Learnt from: Ram-sah19
Repo: RocketChat/Rocket.Chat.Electron PR: 3254
File: .github/workflows/build-release.yml:80-94
Timestamp: 2026-03-11T06:38:40.426Z
Learning: In the RocketChat/Rocket.Chat.Electron repository, the issues flagged in `.github/workflows/build-release.yml` (e.g., `node12` runtime in the release action and missing `snapcraft_token` input), i18n files, and `electron-builder.json` are pre-existing in the `develop` branch and are pulled in during merge conflict resolution. Do not flag these as new issues introduced by PRs that only modify `src/injected.ts` and `src/ui/main/rootWindow.ts`.
📚 Learning: 2026-03-11T06:38:40.426Z 
Learnt from: Ram-sah19
Repo: RocketChat/Rocket.Chat.Electron PR: 3254
File: .github/workflows/build-release.yml:80-94
Timestamp: 2026-03-11T06:38:40.426Z
Learning: In the RocketChat/Rocket.Chat.Electron repository, the issues flagged in `.github/workflows/build-release.yml` (e.g., `node12` runtime in the release action and missing `snapcraft_token` input), i18n files, and `electron-builder.json` are pre-existing in the `develop` branch and are pulled in during merge conflict resolution. Do not flag these as new issues introduced by PRs that only modify `src/injected.ts` and `src/ui/main/rootWindow.ts`.

Applied to files:

  • package.json
🔇 Additional comments (1)
package.json (1)

127-127: LGTM—Electron version update is correct.

The update from 40.0.0 to 40.8.5 follows proper semantic versioning. Electron 40.8.5 is an official release (March 26, 2026) with no known security advisories and is compatible with electron-builder 26.0.3. The included Node.js version (24.14.0) is compatible with the engines requirement on Line 157.

Walkthrough

Updated Electron dev dependency from version 40.0.0 to 40.8.5 in package.json, upgrading the Electron runtime used for building and packaging.

Changes

Cohort / File(s) Summary
Dependency Update
package.json		 Updated electron dev dependency version from 40.0.0 to 40.8.5.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating Electron from version 40.0.0 to 40.8.5, which is the sole modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jeanfbrito jeanfbrito merged commit b3e7144 into dev Apr 1, 2026
7 checks passed
@jeanfbrito jeanfbrito deleted the chore/electron-40.8.5 branch April 1, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type: chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jeanfbrito