build/msiProjectCreated.js (2)

50-65: String-based XML manipulation is functional but fragile.

The current approach uses string replacement to inject WiX elements. This works for electron-builder's predictable output but could break if the generated .wxs structure changes. For a build hook, this pragmatic approach is acceptable, but consider documenting the assumption about the expected XML structure in a comment.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@build/msiProjectCreated.js` around lines 50 - 65, The XML string manipulation
using xml.replace on '</InstallExecuteSequence>' and '</Product>' is fragile;
add a clear comment above this block (referencing the xml variable and the
sequenceEntries and propertyAndActions variables) stating the assumption that
the .wxs output always contains those closing tags in the expected structure and
that this is a pragmatic choice for the build hook; also mention potential risks
and that a proper XML parser should be used if the .wxs structure may vary.

---

26-44: Consider adding error handling to the VBScript custom action.

The VBScript lacks error handling. If the resources folder doesn't exist or there's a permission issue, the installer will fail with a potentially cryptic error due to Return="check". While resources should exist in a typical Electron build (it contains app.asar), adding basic error handling would improve robustness and provide clearer diagnostics.

💡 Optional: Add error handling with descriptive failure

     <CustomAction Id="WriteUpdateJson"
       Script="vbscript"
       Execute="deferred"
       Impersonate="no"
       Return="check">
       <![CDATA[
+        On Error Resume Next
         Dim fso, installDir, filePath, f
         Set fso = CreateObject("Scripting.FileSystemObject")
         installDir = Session.Property("CustomActionData")
         If Right(installDir, 1) <> "\" Then installDir = installDir & "\"
         filePath = installDir & "resources\update.json"
+        If Not fso.FolderExists(installDir & "resources") Then
+          Err.Raise 1, "WriteUpdateJson", "resources folder not found: " & installDir & "resources"
+        End If
         Set f = fso.CreateTextFile(filePath, True)
+        If Err.Number <> 0 Then
+          Err.Raise Err.Number, "WriteUpdateJson", "Failed to create " & filePath & ": " & Err.Description
+        End If
         f.WriteLine "{"
         f.WriteLine "  ""canUpdate"": false,"
         f.WriteLine "  ""autoUpdate"": false"
         f.WriteLine "}"
         f.Close
       ]]>
     </CustomAction>

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@build/msiProjectCreated.js` around lines 26 - 44, The WriteUpdateJson custom
action currently writes update.json without any error handling; wrap the
VBScript in an error-handling block (use On Error Resume Next), ensure the
target folder exists by checking fso.FolderExists on the directory derived from
Session.Property("CustomActionData") and create it with fso.CreateFolder if
missing, and after each filesystem operation check Err.Number and on error call
Session.Log with Err.Number and Err.Description and then raise the error
(Err.Raise) so the installer fails with a clear diagnostic; reference the
CustomAction Id "WriteUpdateJson", the Session.Property("CustomActionData")
value, the filePath variable and the fso.CreateTextFile operation when making
these changes.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes