src/updates/main.ts (1)

349-366: Flag is never reset after user-initiated check completes.

Once isUserInitiatedCheck is set to true, it remains true until the next startup check explicitly resets it. If the application evolves to support additional automatic checks (e.g., periodic checks), they would incorrectly behave as user-initiated. Consider resetting the flag in the update-available, update-not-available, and error event handlers.

Additionally, the try/catch block won't catch errors thrown inside the setTimeout callback. This is mitigated by the autoUpdater.addListener('error', ...) handler (line 321), but the pattern is slightly misleading.

🛠️ Suggested approach: reset flag in event handlers

   autoUpdater.addListener('update-available', ({ version }) => {
     const skippedUpdateVersion = select(
       ({ skippedUpdateVersion }) => skippedUpdateVersion
     );
     if (!isUserInitiatedCheck && skippedUpdateVersion === version) {
       dispatch({ type: UPDATES_NEW_VERSION_NOT_AVAILABLE });
+      isUserInitiatedCheck = false;
       return;
     }
 
     // Prevent showing "updates" that are actually downgrades
     // ...
     dispatch({
       type: UPDATES_NEW_VERSION_AVAILABLE,
       payload: version as string,
     });
+    isUserInitiatedCheck = false;
   });
 
   autoUpdater.addListener('update-not-available', () => {
     dispatch({ type: UPDATES_NEW_VERSION_NOT_AVAILABLE });
+    isUserInitiatedCheck = false;
   });

Also consider adding reset in the error handler if appropriate.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/updates/main.ts` around lines 349 - 366, isUserInitiatedCheck is set to
true in listen(UPDATES_CHECK_FOR_UPDATES_REQUESTED...) but never reset, and the
current try/catch won't catch errors thrown inside the setTimeout callback;
update the code to reset isUserInitiatedCheck = false in the autoUpdater event
handlers 'update-available', 'update-not-available', and 'error' so the flag
only covers the user-initiated window, and ensure errors from the delayed call
are handled by either moving the try/catch inside the setTimeout callback that
calls autoUpdater.checkForUpdates() or explicitly relying on the existing
autoUpdater.addListener('error', ...) handler to dispatch the same
UPDATES_ERROR_THROWN payload (use the same dispatch structure) so exceptions
from autoUpdater.checkForUpdates() are surfaced correctly.