src/ui/main/rootWindow.ts (1)

584-588: The context-menu listener registration is called only once during app initialization, so multiple listener accumulation is not a practical concern.

showRootWindow() is invoked a single time at startup (src/main.ts:104), and the context-menu listener at lines 584–588 is registered once per application lifecycle. The singleton pattern used for _rootWindow ensures the listener is not duplicated.

Additionally, event.preventDefault() on the context-menu event is unnecessary—the event is informational in Electron and has no default behavior to prevent. It can be safely removed.

If you prefer to add defensive guard logic or move listener registration elsewhere for consistency, that would be an optional improvement. The current code functions correctly as-is.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/ui/main/rootWindow.ts` around lines 584 - 588, The context-menu handler
registered via browserWindow.webContents.on('context-menu', ...) calls
event.preventDefault(), which is unnecessary for Electron's informational
'context-menu' event; remove the event.preventDefault() call and leave the
listener registration as-is (it is only created once when showRootWindow()
initializes the singleton _rootWindow). Ensure
createRootWindowContextMenu(params) is still invoked and menu.popup({ window:
browserWindow }) remains unchanged.

src/updates/main.ts (1)

349-366: The try/catch cannot catch errors from checkForUpdates() inside setTimeout.

The checkForUpdates() call is asynchronous within the setTimeout callback, so any thrown error or rejected promise won't be caught by the outer try/catch. While the autoUpdater.addListener('error', ...) at lines 321-330 handles update errors, the try/catch here is misleading.

Additionally, the purpose of the 100ms delay is unclear—consider adding a comment explaining why it's needed.

♻️ Suggested refactor: Move error handling inside setTimeout or remove misleading try/catch

 listen(UPDATES_CHECK_FOR_UPDATES_REQUESTED, async () => {
-  try {
-    isUserInitiatedCheck = true;
-    setTimeout(() => {
+  isUserInitiatedCheck = true;
+  // Delay check to allow UI state to settle (e.g., dialog animation)
+  setTimeout(async () => {
+    try {
       autoUpdater.checkForUpdates();
-    }, 100);
-  } catch (error) {
-    error instanceof Error &&
-      dispatch({
-        type: UPDATES_ERROR_THROWN,
-        payload: {
-          message: error.message,
-          stack: error.stack,
-          name: error.name,
-        },
-      });
-  }
+    } catch (error) {
+      error instanceof Error &&
+        dispatch({
+          type: UPDATES_ERROR_THROWN,
+          payload: {
+            message: error.message,
+            stack: error.stack,
+            name: error.name,
+          },
+        });
+    }
+  }, 100);
 });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/updates/main.ts` around lines 349 - 366, The try/catch around the
listen(UPDATES_CHECK_FOR_UPDATES_REQUESTED, ...) handler cannot catch errors
thrown inside the setTimeout callback; move error handling into that callback
(or remove the outer try/catch) so failures from autoUpdater.checkForUpdates are
caught and dispatched: inside the setTimeout wrap autoUpdater.checkForUpdates in
a try/catch or call autoUpdater.checkForUpdates().catch(...) and dispatch
UPDATES_ERROR_THROWN with error.message/name/stack (use the same payload shape
currently used); also add a short comment explaining why the 100ms delay exists
(or remove the delay if unnecessary) and keep isUserInitiatedCheck assignment
and existing autoUpdater.addListener('error', ...) intact.