Skip to content

chore: align Node version to 24.11.1 across CI and workspaces#3268

Merged
jeanfbrito merged 1 commit intodevfrom
fix/align-node-version-ci
Mar 23, 2026
Merged

chore: align Node version to 24.11.1 across CI and workspaces#3268
jeanfbrito merged 1 commit intodevfrom
fix/align-node-version-ci

Conversation

@jeanfbrito
Copy link
Copy Markdown
Member

@jeanfbrito jeanfbrito commented Mar 19, 2026 •
edited by coderabbitai bot
Loading

Summary

CI workflows and the desktop-release-action workspace were still pinned to Node 22.17.1 while package.json engines, devEngines, and volta all reference 24.11.1.

  • Update node-version in pull-request-build.yml, build-release.yml, and validate-pr.yml from 22.17.1 to 24.11.1
  • Update volta node pin in workspaces/desktop-release-action/package.json from 22.17.1 to 24.11.1

Test plan

  • CI workflows run successfully with Node 24.11.1
  • PR build, release build, and validation all pass

Summary by CodeRabbit

  • Chores
    • Updated Node.js runtime version to 24.11.1 across build and CI/CD pipelines.

@jeanfbrito
chore: align Node version to 24.11.1 across CI and workspaces
45469d9 
CI workflows and the desktop-release-action workspace were still
pinned to Node 22.17.1 while package.json engines, devEngines, and
volta all reference 24.11.1.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 19, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 382064c5-bd65-45b0-bc5b-c01d31f8ed51

📥 Commits

Reviewing files that changed from the base of the PR and between 0790d9f and 45469d9.

📒 Files selected for processing (4)
  • .github/workflows/build-release.yml
  • .github/workflows/pull-request-build.yml
  • .github/workflows/validate-pr.yml
  • workspaces/desktop-release-action/package.json
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: check (macos-latest)
  • GitHub Check: check (windows-latest)
  • GitHub Check: check (ubuntu-latest)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings 
Learnt from: Ram-sah19
Repo: RocketChat/Rocket.Chat.Electron PR: 3254
File: .github/workflows/build-release.yml:80-94
Timestamp: 2026-03-11T06:38:40.426Z
Learning: In the RocketChat/Rocket.Chat.Electron repository, the issues flagged in `.github/workflows/build-release.yml` (e.g., `node12` runtime in the release action and missing `snapcraft_token` input), i18n files, and `electron-builder.json` are pre-existing in the `develop` branch and are pulled in during merge conflict resolution. Do not flag these as new issues introduced by PRs that only modify `src/injected.ts` and `src/ui/main/rootWindow.ts`.
📚 Learning: 2026-03-11T06:38:40.426Z 
Learnt from: Ram-sah19
Repo: RocketChat/Rocket.Chat.Electron PR: 3254
File: .github/workflows/build-release.yml:80-94
Timestamp: 2026-03-11T06:38:40.426Z
Learning: In the RocketChat/Rocket.Chat.Electron repository, the issues flagged in `.github/workflows/build-release.yml` (e.g., `node12` runtime in the release action and missing `snapcraft_token` input), i18n files, and `electron-builder.json` are pre-existing in the `develop` branch and are pulled in during merge conflict resolution. Do not flag these as new issues introduced by PRs that only modify `src/injected.ts` and `src/ui/main/rootWindow.ts`.

Applied to files:

  • .github/workflows/validate-pr.yml
🔇 Additional comments (4)
workspaces/desktop-release-action/package.json (1)

40-40: Volta Node pin update is correct and consistent.

This cleanly aligns the workspace runtime with the CI Node version bump.

.github/workflows/pull-request-build.yml (1)

43-46: Node setup update looks good.

Step label and node-version are in sync at 24.11.1, which keeps this workflow aligned with the rest of the PR.

.github/workflows/validate-pr.yml (1)

30-33: Validation workflow Node bump is correct.

This is consistent with the CI/runtime alignment goal and keeps the step metadata accurate.

.github/workflows/build-release.yml (1)

35-38: Release workflow Node setup change is solid.

actions/setup-node is correctly pinned to 24.11.1, matching the rest of this PR’s version alignment.

Walkthrough

Updated Node.js runtime version from 22.17.1 to 24.11.1 across three GitHub Actions workflows and one package.json configuration file. No functional logic or dependencies were modified.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/build-release.yml, .github/workflows/pull-request-build.yml, .github/workflows/validate-pr.yml		 Updated actions/setup-node@v4 configuration from Node 22.17.1 to Node 24.11.1 by changing step names and node-version inputs.
Volta Runtime Configuration
workspaces/desktop-release-action/package.json		 Updated Volta-managed Node.js runtime version from 22.17.1 to 24.11.1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: align Node version to 24.11.1 across CI and workspaces' accurately summarizes the main change: updating Node.js from 22.17.1 to 24.11.1 across CI workflows and workspace configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jeanfbrito jeanfbrito merged commit 813fcc8 into dev Mar 23, 2026
7 checks passed
@jeanfbrito jeanfbrito deleted the fix/align-node-version-ci branch March 23, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type: chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jeanfbrito