Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: RocketChat/Rocket.Chat.Electron
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.14.0-alpha.0
Choose a base ref
...
head repository: RocketChat/Rocket.Chat.Electron
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4.14.0-alpha.1
Choose a head ref
  • 2 commits
  • 40 files changed
  • 1 contributor

Commits on Mar 27, 2026

  1. feat: add DISABLE_AUTO_UPDATES property to MSI installer (#3280) 

    * feat: add DISABLE_AUTO_UPDATES property to MSI installer

Allow enterprise admins to disable auto-updates during MSI deployment:
msiexec /i rocketchat.msi DISABLE_AUTO_UPDATES=1 /qn

Uses electron-builder's msiProjectCreated hook to inject a WiX custom
action that writes resources/update.json with canUpdate and autoUpdate
set to false, matching the existing NSIS /disableAutoUpdates behavior.

* Harden VBScript custom action and add build-time validation

- Add error handling to VBScript: check resources/ exists, validate
  file creation, and raise descriptive errors on failure
- Guard custom action with NOT REMOVE~="ALL" to skip during uninstall
- Add build-time validation that throws if XML injection failed
- Document implementation assumptions in JSDoc header

* chore: bump version to 4.14.0-alpha.1

* ci: include MSI artifacts in PR builds

Add MSI target to the Windows electron-builder command and include
.msi files in Wasabi uploads and PR comment artifact links.
    @jeanfbrito
    jeanfbrito authored Mar 27, 2026
    Configuration menu
    Copy the full SHA
    4da3644 View commit details
    Browse the repository at this point in the history

  2. feat: Add markdown file viewer with GitHub-flavored rendering (#3277) 

    * feat: add markdown file viewer with GitHub-flavored rendering

Extend the document viewer to support markdown files alongside PDFs.
When a .md file is clicked in a server, it is intercepted at the
download level and rendered in an overlay using marked with GFM support,
syntax highlighting via highlight.js, and DOMPurify for XSS sanitization.

- Add MarkdownContent component with GitHub-style CSS and theme support
- Extract PdfContent into its own component for cleaner separation
- Thread documentViewerFormat through Redux state and IPC
- Intercept .md downloads via session will-download handler
- Fetch markdown content via main process IPC using server session auth
- Open links in external browser, contain scroll within viewer
- Add document viewer translation keys

* i18n: add document viewer translations for all languages

Add documentViewer.title.pdf and documentViewer.title.markdown
translation keys to all 21 non-English locale files.

* fix: address code review — security, accessibility, and link handling

- Validate URL protocol and origin in fetch-content IPC handler
- Use getAttribute('href') for links, resolve relative URLs against
  document base, and enforce protocol allowlist (http, https, mailto)
- Skip in-page anchor links (#) instead of opening externally
- Add aria-label to back button for screen readers
- Replace raw <h2> with Fuselage Box fontScale for theme consistency
- Add documentViewer.back translation key to all 22 languages

* fix: preserve in-page anchor scrolling in markdown viewer

Move preventDefault() after the hash-link check so that #anchor
links retain their default scrolling behavior.
    @jeanfbrito
    jeanfbrito authored Mar 27, 2026
    Configuration menu
    Copy the full SHA
    f5be646 View commit details
    Browse the repository at this point in the history
Loading