fix: address second round of PR review findings

jeanfbrito · jeanfbrito · commit 99751af85e50 · 2026-03-02T16:55:19.000-03:00
- Dedup file hook: serialize structured objects with JSON.stringify
  instead of String() to produce meaningful dedup keys
- Privacy: guard redactObject spread against non-object return value
  when processing nested Redux state
diff --git a/src/logging/dedup.ts b/src/logging/dedup.ts
@@ -66,7 +66,17 @@ export class LogDeduplicator {
       if (transportName !== 'file') return message;
       if (!message || message.level === 'error') return message;
 
-      const text = message.data?.map(String).join(' ') || '';
+      const text =
+        message.data
+          ?.map((item: any) => {
+            if (typeof item === 'string') return item;
+            try {
+              return JSON.stringify(item);
+            } catch {
+              return String(item);
+            }
+          })
+          .join(' ') || '';
       const key = `${message.level}|${text.replace(/\b\d{4,}\b/g, '#').replace(/\b\d+\.\d+\b/g, '#')}`;
 
       if (key === this.lastFileKey) return null; // suppress duplicate
diff --git a/src/logging/privacy.ts b/src/logging/privacy.ts
@@ -277,10 +277,11 @@ const redactObject = (obj: any, depth = 0, seen = new WeakSet()): any => {
     }
     if (obj.state && isStateDump(obj.state)) {
       const { state: _state, ...rest } = obj;
-      return {
-        ...redactObject(rest, depth + 1, seen),
-        state: '[Redux State Redacted]',
-      };
+      const redactedRest = redactObject(rest, depth + 1, seen);
+      if (typeof redactedRest === 'object' && redactedRest !== null) {
+        return { ...redactedRest, state: '[Redux State Redacted]' };
+      }
+      return { state: '[Redux State Redacted]' };
     }
 
     const result: any = {};
