fix: add safeSelect for preload context and guard getInternalVideoChatWindowEnabled

jeanfbrito · jeanfbrito · commit 50e1d47c71d2 · 2026-02-19T17:41:00.000-03:00
select() has no null guard by design — it crashes loudly if called before
store initialization, which is correct for the main process where the store
is always ready before any select() call.

Add safeSelect() for preload contexts where the store may not yet be
initialized. Unlike select(), it returns T | undefined and TypeScript
enforces that callers handle the undefined case.

Use safeSelect in getInternalVideoChatWindowEnabled() with an explicit
?? false fallback, so early calls before store init return false (safe
default) instead of crashing or silently returning undefined-as-boolean.
diff --git a/src/servers/preload/internalVideoChatWindow.ts b/src/servers/preload/internalVideoChatWindow.ts
@@ -1,12 +1,12 @@
 import { ipcRenderer } from 'electron';
 
-import { select } from '../../store';
+import { safeSelect } from '../../store';
 import { openExternal } from '../../utils/browserLauncher';
 
 export const getInternalVideoChatWindowEnabled = (): boolean =>
-  select(
+  safeSelect(
     ({ isInternalVideoChatWindowEnabled }) => isInternalVideoChatWindowEnabled
-  );
+  ) ?? false;
 
 export type videoCallWindowOptions = {
   providerName?: string | undefined;
diff --git a/src/store/index.ts b/src/store/index.ts
@@ -66,6 +66,11 @@ type Selector<T> = (state: RootState) => T;
 export const select = <T>(selector: Selector<T>): T =>
   selector(reduxStore.getState());
 
+export const safeSelect = <T>(selector: Selector<T>): T | undefined => {
+  if (!reduxStore) return undefined;
+  return selector(reduxStore.getState());
+};
+
 export const watch = <T>(
   selector: Selector<T>,
   watcher: (curr: T, prev: T | undefined) => void
