This repository was archived by the owner on Nov 5, 2025. It is now read-only.
[NEW] Add support for the "encoding" option in HTTP requests#321
Merged
[NEW] Add support for the "encoding" option in HTTP requests#321
Conversation
Codecov Report
@@ Coverage Diff @@
## beta #321 +/- ##
==========================================
+ Coverage 50.80% 52.76% +1.95%
==========================================
Files 75 83 +8
Lines 2850 2968 +118
Branches 433 433
==========================================
+ Hits 1448 1566 +118
Misses 1402 1402
Continue to review full report at Codecov.
|
12 tasks
d-gubert
changed the title
http accessor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? ⛵
Add a new optional property
encodingto the interface IHttpRequestWhy? 🤔
Make sure we can using
http.getto download binary data correctly.Links 🌎
https://open.rocket.chat/group/t9xgtnadgqwf3xkzh?msg=x5EsHiqtzv7rJj3qR (Private)
PS 👀
The PR on the RocketChat side: RocketChat/Rocket.Chat#19002