Codecov Report

Merging #229 into master will decrease coverage by 0.31%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #229      +/-   ##
=========================================
- Coverage   53.81%   53.5%   -0.32%     
=========================================
  Files          70      70              
  Lines        2568    2583      +15     
  Branches      380     380              
=========================================
  Hits         1382    1382              
- Misses       1186    1201      +15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c4e8e...4a5d4f8. Read the comment docs.

The current implementation allows a discussion to be created without a parent/origin message in the parent room. Is this something we'd like to allow? @marceloschmidt @ggazzo @sampaiodiego

Now that you mentioned, it doesn't seem to make much sense.

Though, do we have this type of logic here?

@marceloschmidt The API as it is allows that to happen as much as the implementation on the Rocket.Chat side, so if we want to change something, we're gonna have to change in both places 😛

I think the best thing we could do here for the developer is to provide a createDiscussion(discussion: IRoom, origin: IMessage) method, which would create the discussion AND the origin/parent message if needed.

The only problem is... where do we put it? In the IModify interface? 🤔

on Rocket.Chat side we have a createDiscussion method that handles everything, you can provide either a roomId or a messageId..

I think the best thing we could do here for the developer is to provide a createDiscussion(discussion: IRoom, origin: IMessage) method, which would create the discussion AND the origin/parent message if needed.

an API like this makes more sense to me 👍

Oooh, I've recently come to realize that a message is always created along with a discussion, even if the user clicks on the Start a discussion message action 😬 So if we were to create a bridge method that calls the createDiscussion method on the Rocket.Chat side, it looks like a perfect solution then?

I might be able to give this a try today

@d-gubert did you manage to do it?

I'm closing this one in favor of a different branch with the proposed approach.