[IMPROVE] Filter markdown in notifications#9995
Merged
rodrigok merged 9 commits intoRocketChat:developfrom Apr 21, 2020
Merged
Conversation
c0dzilla
force-pushed
the
markdown-filter
branch
from
6f0822b to
43ffb4d
Compare
c0dzilla
force-pushed
the
markdown-filter
branch
6 times, most recently
from
1503b79 to
b9601ba
Compare
c0dzilla
force-pushed
the
markdown-filter
branch
3 times, most recently
from
37fc644 to
d5ef312
Compare
c0dzilla
force-pushed
the
markdown-filter
branch
from
d5ef312 to
9b82798
Compare
Member
|
@c0dzilla can you check the unit tests? |
c0dzilla
force-pushed
the
markdown-filter
branch
from
cd0f7ae to
7ccec1f
Compare
c0dzilla
force-pushed
the
markdown-filter
branch
from
7ccec1f to
456f0ee
Compare
Contributor
Author
|
@rodrigok fixed the tests. |
|
|
rodrigok
requested changes
Apr 20, 2020
rodrigok
approved these changes
Apr 20, 2020
rodrigok
requested changes
Apr 21, 2020
rodrigok
approved these changes
Apr 21, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9979
This pr adds a filter to remove markdown tags from desktop/push notifications.
Example:
gives notification
