[FIX] web app manifest errors as reported by Chrome DevTools#9991
Merged
ggazzo merged 5 commits intoRocketChat:developfrom Jul 5, 2018
justinribeiro:fix-web-app-manifest-errors
Merged
[FIX] web app manifest errors as reported by Chrome DevTools#9991ggazzo merged 5 commits intoRocketChat:developfrom justinribeiro:fix-web-app-manifest-errors
ggazzo merged 5 commits intoRocketChat:developfrom
justinribeiro:fix-web-app-manifest-errors
Conversation
ggazzo
approved these changes
Jul 5, 2018
ggazzo
added
the
area: ui/ux
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9990
This pull request properly brings the web app manifest up-to-date to the current specification and resolves the incorrect start_url origin and the path to the broken images as seen in this screenshot.
This resolves the unwanted and incorrect behavior experienced in both Google Chrome and Mozilla Firefox for Android.