Skip to content

[FIX] Misplaced "Save Changes" button in user account panel#9888

Merged
rodrigok merged 1 commit intoRocketChat:developfrom
kaiiiiiiiii:remove_hardcoded_max_width_from_save_changes_button_in_user_account_ui
Feb 26, 2018
Merged

[FIX] Misplaced "Save Changes" button in user account panel#9888
rodrigok merged 1 commit intoRocketChat:developfrom
kaiiiiiiiii:remove_hardcoded_max_width_from_save_changes_button_in_user_account_ui

Conversation

@kaiiiiiiiii
Copy link
Copy Markdown
Contributor

@RocketChat/core

Closes #9886

This PR removes the hardcoded max-width in the user account panel which caused the save changes button to look different than in the admin ui.

Before:
screen shot 2018-02-24 at 16 31 12

After:
screen shot 2018-02-24 at 16 31 28

Admin UI:
screen shot 2018-02-24 at 16 38 25

@kaiiiiiiiii kaiiiiiiiii changed the title [FIX] "Saves changes" button in user account settings has hardcoded max-width [FIX] Misplaced "Save Changes" button in user account panel due to hardcoded max-width. Feb 24, 2018
@rodrigok rodrigok requested review from ggazzo and karlprieb February 26, 2018 13:45
@rodrigok rodrigok added this to the 0.62.0 milestone Feb 26, 2018
@rodrigok rodrigok changed the title [FIX] Misplaced "Save Changes" button in user account panel due to hardcoded max-width. [FIX] Misplaced "Save Changes" button in user account panel Feb 26, 2018
@rodrigok rodrigok merged commit df8ec68 into RocketChat:develop Feb 26, 2018
@kaiiiiiiiii kaiiiiiiiii deleted the remove_hardcoded_max_width_from_save_changes_button_in_user_account_ui branch February 26, 2018 17:18
@rodrigok rodrigok mentioned this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants