[FIX] Parsing messages with multiple markdown matches ignore some tokens#9884
Merged
rodrigok merged 2 commits intoRocketChat:developfrom Feb 26, 2018
Merged
[FIX] Parsing messages with multiple markdown matches ignore some tokens#9884rodrigok merged 2 commits intoRocketChat:developfrom
rodrigok merged 2 commits intoRocketChat:developfrom
Conversation
c0dzilla
force-pushed
the
parse
branch
2 times, most recently
from
ae65cf0 to
a077374
Compare
Member
|
Thanks @c0dzilla What do you think about use example: - for (const {token, text} of message.tokens) {
+ for (const {token, text} of message.tokens.reverse()) { |
Contributor
Author
|
@rodrigok I've made the change. |
rodrigok
approved these changes
Feb 26, 2018
rodrigok
changed the title
Merged
|
Thanks for fixing Guys 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9854 #9758
The message body was containing a random string of the form '=!=randomInteger=!=' many times whenever the message had multiple markdown matches(for example a url with inline code). This was because the tokens were being unmounted in the order in which they were attached during parsing, leading to misses when a token was overwritten by another token as in the case of mutiple matches. This pr changes unmounting order to LIFO to fix this.
Example:
now parsed as