Conversation
Since we flattened things a bit that folder didn't exist any more.
Contributor
Author
|
We did get this from snap store... so we may need to do further work to it.
Triggered a manual review |
rodrigok
approved these changes
Feb 24, 2018
Merged
|
Might this be related? #9992 Cheers |
Contributor
Author
|
Yes this fixed the actual build failure. Now it's getting hung up on the store review. I've left a comment on that issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we flattened things a bit that folder didn't exist any more.
This will fix the snap build.
https://launchpad.net/~rocket.chat.buildmaster/+snap/candidate/+build/155010 build that succeeded after these changes.