Skip to content

Regression: Change create channel icon#9851

Merged
rodrigok merged 2 commits intodevelopfrom
change-create-channel-icon
Feb 23, 2018
Merged

Regression: Change create channel icon#9851
rodrigok merged 2 commits intodevelopfrom
change-create-channel-icon

Conversation

@karlprieb
Copy link
Copy Markdown
Contributor

@karlprieb karlprieb commented Feb 22, 2018

@RocketChat/core

image

@karlprieb karlprieb added this to the 0.62.0 milestone Feb 22, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9851 February 22, 2018 21:50 Inactive
@engelgabriel
Copy link
Copy Markdown
Member

engelgabriel commented Feb 22, 2018

@karlprieb you need to fix the test:

1) [Main Elements Render]
       [Side Nav Bar]
         render:
           it should show the new channel button:

      Uncaught AssertionError: expected false to be true
      + expected - actual

      -false
      +true

@rodrigok rodrigok changed the title Regression: change create channel icon Regression: Change create channel icon Feb 23, 2018
@rodrigok rodrigok merged commit 53be5e9 into develop Feb 23, 2018
@rodrigok rodrigok deleted the change-create-channel-icon branch February 23, 2018 20:10
@rodrigok rodrigok mentioned this pull request Feb 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rodrigok rodrigok Awaiting requested review from rodrigok

@ggazzo ggazzo Awaiting requested review from ggazzo

1 more reviewer

@gdelavald gdelavald gdelavald approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.62.0

Development

Successfully merging this pull request may close these issues.

4 participants

@karlprieb @engelgabriel @gdelavald @rodrigok