Conversation
Contributor
|
Can we display the 'update your instance' only for admins? Seems more reasonable than showing to every user on the server. |
Contributor
|
Agreed! Maybe a role filter on the alerts so can restrict to just admin? Also will this show every time they restart an instance(single instance or multiple instance situations) |
Member
|
it IS already filtering only admins |
Contributor
|
oh duh! 😊 I might be missing cause I did the last part :) but looks like once you dismiss it deletes the banner. What's to keep it from showing up again? Or if I restart an instance it showing up again? |
rodrigok
force-pushed
the
version-update-check
branch
from
09a47ba to
033985e
Compare
rodrigok
force-pushed
the
version-update-check
branch
from
033985e to
e860c05
Compare
Member
Author
|
@geekgonecrazy if you click to see more information the banner will not close, but if you close it will be removed from database and will not be showed again until we release a new version. |
rodrigok
force-pushed
the
version-update-check
branch
from
e860c05 to
26b95cb
Compare
rodrigok
force-pushed
the
version-update-check
branch
from
26b95cb to
b81b366
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9542