Skip to content

[NEW] General alert banner#9778

Merged
rodrigok merged 16 commits intodevelopfrom
alerts
Feb 21, 2018
Merged

[NEW] General alert banner#9778
rodrigok merged 16 commits intodevelopfrom
alerts

Conversation

@ggazzo
Copy link
Copy Markdown
Member

@ggazzo ggazzo commented Feb 20, 2018 •
edited
Loading

  • small version
  • actions
  • close
  • large version
  • deal with large texts
  • timer to close

@RocketChat/core

how to use

alerts.open({html: '<b>Update your Rocket Chat.</b> New version available (v0.65)', action(){alert('hi')}}) 
// or
alerts.open({text: ' Update your Rocket Chat. New version available (v0.65)', action(){alert('hi')}}) 

const params = 
{ 
    title: 'insert your title' ,// bold
    text:'put some text here',
    html:'you can use html to',
    closable:  false, //default
    action: function() { /* some function to be executed on click */ },
    timer: null // time in ms, default none,
    icon: null, 
    modifiers:[...] // ex: ['large'] will set rc-alerts--large class
}

Desktop

image

Mobile

image

large modifier

Desktop

image

Mobile

image

demo

1qrfgg2boh

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9778 February 20, 2018 03:59 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-9778 February 20, 2018 04:03 Inactive
@RocketChat RocketChat deleted a comment Feb 20, 2018
@RocketChat RocketChat deleted a comment Feb 20, 2018
@RocketChat RocketChat deleted a comment Feb 20, 2018
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-9778 February 20, 2018 04:11 Inactive
@RocketChat RocketChat deleted a comment Feb 20, 2018
@RocketChat RocketChat deleted a comment Feb 20, 2018
@RocketChat RocketChat deleted a comment Feb 20, 2018
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-9778 February 20, 2018 05:00 Inactive
@RocketChat RocketChat deleted a comment Feb 20, 2018
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-9778 February 20, 2018 05:27 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-9778 February 20, 2018 05:29 Inactive
@ggazzo ggazzo changed the title [WIP][NEW] General Alerts [NEW] General Alerts Feb 20, 2018
@RocketChat RocketChat deleted a comment Feb 20, 2018
@sampaiodiego
Copy link
Copy Markdown
Member

sampaiodiego commented Feb 20, 2018

I think the font-size should be a bit smaller.. same size as channel name for example

@ggazzo ggazzo temporarily deployed to rocket-chat-pr-9778 February 20, 2018 14:22 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-9778 February 20, 2018 16:25 Inactive
@ggazzo
Copy link
Copy Markdown
Member Author

ggazzo commented Feb 20, 2018

@sampaiodiego changed the font size

@ggazzo ggazzo temporarily deployed to rocket-chat-pr-9778 February 20, 2018 17:02 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-9778 February 20, 2018 18:16 Inactive
karlprieb
karlprieb approved these changes Feb 20, 2018
View reviewed changes
packages/rocketchat-ui/client/views/app/alerts.js
});

Template.alerts.helpers({
isSafariIos: /iP(ad|hone|od).+Version\/[\d\.]+.*Safari/i.test(navigator.userAgent)
Copy link
Copy Markdown
Contributor

@karlprieb karlprieb Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you using this helper?

Copy link
Copy Markdown
Member Author

@ggazzo ggazzo Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet... I think that helper should be a global one..

@ggazzo ggazzo temporarily deployed to rocket-chat-pr-9778 February 20, 2018 19:51 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-9778 February 20, 2018 22:32 Inactive
@rodrigok rodrigok mentioned this pull request Feb 20, 2018
Merged
6 tasks
@rodrigok rodrigok added this to the 0.62.0 milestone Feb 20, 2018
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-9778 February 20, 2018 23:47 Inactive
@rodrigok rodrigok changed the title [NEW] General Alerts [NEW] General alert banner Feb 21, 2018
@rodrigok rodrigok merged commit e92e59b into develop Feb 21, 2018
@rodrigok rodrigok deleted the alerts branch February 21, 2018 02:37
@rodrigok rodrigok mentioned this pull request Feb 28, 2018
Merged
@raymondfeliz
Copy link
Copy Markdown

raymondfeliz commented Mar 1, 2018

My apologies, I see that there is a section for "How to use" but im not exactly sure how to use this feature. Is there a place where I have to insert those lines? Im sorry if this is a silly question! :(

I updated a test server of mine to 0.62.0 just to play with this specific feature, im extremely grateful that you added this!

@geekgonecrazy
Copy link
Copy Markdown
Contributor

geekgonecrazy commented Mar 1, 2018

It's an internal API level feature. It can be used from another package. In the future it might be exposed in other ways

@raymondfeliz
Copy link
Copy Markdown

raymondfeliz commented Mar 1, 2018

Is there perhaps a ste-by-step guide with an example on how to use this feature?

I went ahead and started trying to figure it out but havent gotten far sadly.

I can query and auth against the API with

curl -H "Content-type:application/json"
http://localhost:3000/api/v1/login
-d '{ "username": "--username--", "password": "--password--" }'

From there I have an auth token and a user ID to execute other api calls, but I cant figure out how to call on yours. Im sure its something really simple that im not aware of.

Im thinking of writing a quick little web app to interact with the API to change these messages from a gui once I figure out how the calls are made.

Thanks in advance!

@geekgonecrazy
Copy link
Copy Markdown
Contributor

geekgonecrazy commented Mar 1, 2018

Its not exposed via the rest api. Its an internal api. Which means you would have to create a meteor package and compile it to use it.

I'm not sure on the plans, but a rest api endpoint my be created to allow using it that way.

@geekgonecrazy geekgonecrazy mentioned this pull request Apr 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rodrigok rodrigok rodrigok approved these changes

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

+2 more reviewers

@gdelavald gdelavald gdelavald approved these changes

@karlprieb karlprieb karlprieb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.62.0

Development

Successfully merging this pull request may close these issues.

8 participants

@ggazzo @sampaiodiego @raymondfeliz @geekgonecrazy @rodrigok @gdelavald @karlprieb @engelgabriel