[FIX] Parse inline code without space before initial backtick#9754
Merged
ggazzo merged 7 commits intoRocketChat:developfrom Jul 5, 2018
Merged
[FIX] Parse inline code without space before initial backtick#9754ggazzo merged 7 commits intoRocketChat:developfrom
ggazzo merged 7 commits intoRocketChat:developfrom
Conversation
Contributor
Author
|
The test that it is failing is checking exactly what #9553 complains about.
Is there some reason why the regex has been written like this that I'm unaware of? Or should the test be modified? |
Contributor
Author
|
@geekgonecrazy is there some reason why the test is checking that inline code without initial space is not parsed? |
Contributor
|
I'm not sure. Feel free to adjust the test to test the functionality if that's not enough to fully test |
Contributor
Author
|
@geekgonecrazy I've modified the test. |
gdelavald
approved these changes
Jun 12, 2018
ggazzo
added
the
area: ui/ux
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Modified regex in matching function.
Closes #9553
Earlier:
Now:
