Skip to content

Move NRR package to inside the project and convert from CoffeeScript#9753

Merged
engelgabriel merged 2 commits intodevelopfrom
move-nrr-inside
Feb 20, 2018
Merged

Move NRR package to inside the project and convert from CoffeeScript#9753
engelgabriel merged 2 commits intodevelopfrom
move-nrr-inside

Conversation

@rodrigok
Copy link
Copy Markdown
Member

@RocketChat/core

Closes #9544

Livechat still depends on old package

@rodrigok rodrigok added this to the 0.62.0 milestone Feb 17, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9753 February 17, 2018 12:34 Inactive
@rodrigok rodrigok self-assigned this Feb 17, 2018
@sampaiodiego
Copy link
Copy Markdown
Member

sampaiodiego commented Feb 17, 2018

I don't see any reason for this =\

Especially if livechat will still depend on the old one

@engelgabriel
Copy link
Copy Markdown
Member

@sampaiodiego

Especially if livechat will still depend on the old one

Not for long.

@engelgabriel engelgabriel merged commit 88d305f into develop Feb 20, 2018
@engelgabriel engelgabriel deleted the move-nrr-inside branch February 20, 2018 02:43
@rodrigok rodrigok mentioned this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Non-Reactive Render package into main project

3 participants