[NEW] Makes shield icon configurable#9746
Conversation
geekgonecrazy
left a comment
geekgonecrazy
left a comment
There was a problem hiding this comment.
Ideally we want to keep it so a user never edits the local files. It should be possible in the UI. We have many cases where the filesystem Rocket.Chat is on is read only.
My suggestion would be to change it to actually make use of the svg icon that can be uploaded in assets: a
That way will make use of the very same icon used as favicon.
|
@geekgonecrazy should there be a separate icon called shield in the assets ui or the favicon icon itself be used? |
|
In my opinion making use of the same exact icon would be desirable for the end user. Less for them to have to upload and maintain. This way they upload their logo once and its used everywhere its needed. |
|
Made requested changes. |
geekgonecrazy
left a comment
geekgonecrazy
left a comment
There was a problem hiding this comment.
Tried it out, looks good!
3 participants
@RocketChat/core
Closes #6989
This pr makes the shield icon in the shield.svg api route configurable. Desired svg image can be added in the public/images/shield/shield-icon.svg file to replace the default rocket.chat icon.
Example:
