Conversation
sampaiodiego
approved these changes
Feb 14, 2018
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
should this be listed as [BREAK] since it removes the method detectGM and the GraphicsMagick field from RocketChat.Info?
rodrigok
changed the title
Contributor
|
How are images scaled after this PR has been applied? Are there any new system components to be installed instead of Graphics/Image Magick? |
Contributor
|
It now makes use of a nodejs module to handle the resizing called sharp. Personally not intimately familiar with it.. but from what I can tell it's written in rust. I think the idea is to of course remove dependence on imagemagick... Always shows up in our image scan with risk. The other is something a bit easier and more native. |
Merged
Contributor
|
Great thanks for your answer @geekgonecrazy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.