[FIX] Show custom room types icon in channel header#9696
Merged
rodrigok merged 2 commits intoRocketChat:developfrom Feb 17, 2018
Merged
[FIX] Show custom room types icon in channel header#9696rodrigok merged 2 commits intoRocketChat:developfrom
rodrigok merged 2 commits intoRocketChat:developfrom
Conversation
rodrigok
approved these changes
Feb 17, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes assistify#222
This PR makes use of the custom room type's icon not only in the side nav, bar also in the header of the channel.
@RocketChat/core feel free to move the hard-coded values in the template helper to the room type interface definition as well ;)