[FIX] Missing string 'There_are_no_applications' on the OAuth Apps Page#9626
Merged
rodrigok merged 4 commits intoRocketChat:masterfrom Feb 8, 2018
kaiiiiiiiii:master
Merged
[FIX] Missing string 'There_are_no_applications' on the OAuth Apps Page#9626rodrigok merged 4 commits intoRocketChat:masterfrom kaiiiiiiiii:master
rodrigok merged 4 commits intoRocketChat:masterfrom
kaiiiiiiiii:master
Conversation
|
|
kaiiiiiiiii
changed the title
kaiiiiiiiii
changed the title
graywolf336
reviewed
Feb 7, 2018
| "theme-custom-css": "Custom CSS", | ||
| "theme-font-body-font-family": "Body Font Family", | ||
| "There_are_no_agents_added_to_this_department_yet": "There are no agents added to this department yet.", | ||
| "There_are_no_applications": "There are no OAuth Applications added yet.", |
Contributor
There was a problem hiding this comment.
I wonder, would it make more sense to have it worded: "No oAuth Applications have been added yet."? I'm not 100% sure 🤔
Contributor
Author
There was a problem hiding this comment.
Definitely makes more sense. I’m gonna change that later. Should I change the variable name as well?
Contributor
There was a problem hiding this comment.
I don't think so, should be fine with how it currently is. Thanks!
Contributor
Author
|
Sorry for this mess of a PR, but I think I'm done :) |
graywolf336
approved these changes
Feb 8, 2018
Contributor
graywolf336
left a comment
graywolf336
left a comment
There was a problem hiding this comment.
Thanks for the fix and making the update! :)
rodrigok
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9627
Sorry for any mistakes. This is my first PR ever :)