[FIX] SVG avatars are not been displayed correctly when load in non HTML containers#9570
Merged
rodrigok merged 2 commits intoRocketChat:developfrom Feb 8, 2018
philipbrito:improvement/avatar
Merged
[FIX] SVG avatars are not been displayed correctly when load in non HTML containers#9570rodrigok merged 2 commits intoRocketChat:developfrom philipbrito:improvement/avatar
rodrigok merged 2 commits intoRocketChat:developfrom
philipbrito:improvement/avatar
Conversation
This was referenced Feb 1, 2018
karlprieb
approved these changes
Feb 6, 2018
Contributor
|
Is this one ready to merge guys? |
rodrigok
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
This PR updates the way of how the avatar (the SVG file) is built. It adds the corners rounded to the file, making the mobile apps render it as shown in the web application.
Additional information about the need for this PR can be found here: RocketChat/Rocket.Chat.Android#729