[NEW] Add route to get user shield/badge#9549
Merged
rodrigok merged 4 commits intoRocketChat:developfrom Feb 8, 2018
Merged
Conversation
|
|
|
Choosing black as the text color would benefit all but the red version. Or dial the background way darker – bad contrast plagues the current RC default theme, no need to extend that to the shields. |
Contributor
Author
|
I have made the background darker. Please check the following and suggest further changes. I will update the PR accordingly.
Hex values : #1FB31F, #DC9B01, #BC2031, #A5A1A1 |
Contributor
|
Looking good 👍 once you make the changes, I'll take a look |
Contributor
Author
|
@graywolf336 |
graywolf336
approved these changes
Feb 1, 2018
Contributor
graywolf336
left a comment
graywolf336
left a comment
There was a problem hiding this comment.
Looks and works good, testing locally. Thanks for the pull request!
rodrigok
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9488
Add route:
/api/v1/shield.svg?type=user&username=USERNAMEDisplays user's
nameandstatusas follows:Please guide me how can I improve the code further. Thank You.