[FIX] Missing link Site URLs in enrollment e-mails#9454
Merged
rodrigok merged 1 commit intoRocketChat:developfrom Feb 8, 2018
Merged
[FIX] Missing link Site URLs in enrollment e-mails#9454rodrigok merged 1 commit intoRocketChat:developfrom
rodrigok merged 1 commit intoRocketChat:developfrom
Conversation
graywolf336
approved these changes
Jan 22, 2018
rodrigok
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
This patch turns
[Site_URL]into<a href="[Site_URL]">[Site_URL]</a>in the internationalization texts for new-user e-mails. That way, invited users can click the link, rather than copying and pasting it, when their mail clients don't hyperlink automatically. I can confirm that my mail client---FastMail web mail---does not.I have manually reviewed the English, Spanish, and Russian changes, to ensure they make sense in context. I'm afraid I don't speak all the other languages!