[NEW] Allow sounds when conversation is focused#9312
Merged
rodrigok merged 7 commits intoRocketChat:developfrom Feb 15, 2018
Merged
[NEW] Allow sounds when conversation is focused#9312rodrigok merged 7 commits intoRocketChat:developfrom
rodrigok merged 7 commits intoRocketChat:developfrom
Conversation
|
|
Contributor
Author
|
I wasn't sure how you do internationalization, so only English is implemented. Let me know if you need any work on my part to add other languages. |
t-mullen
commented
Jan 2, 2018
| if (audio) { | ||
| const $audio = $(`audio#${ audio }`); | ||
| return $audio && $audio[0] && $audio.play(); | ||
| return $audio && $audio[0] && $audio[0].play(); |
Contributor
Author
There was a problem hiding this comment.
Here was the audio preview bug. It was calling "play" on an array instead of the first HTML5 audio object.
t-mullen
changed the title
t-mullen
commented
Jan 3, 2018
| @@ -42,10 +43,14 @@ Meteor.startup(function() { | |||
| KonchatNotification.newMessage(notification.payload.rid); | |||
Contributor
Author
There was a problem hiding this comment.
I'm not clear on why embeds only fire notifications when the room is focused, instead of unfocused. I'm 99% sure this is an existing bug, but I've left it as is for now. (L40-41 above)
|
Any chance to get this merged? |
graywolf336
approved these changes
Feb 2, 2018
Contributor
graywolf336
left a comment
graywolf336
left a comment
There was a problem hiding this comment.
Looks good, thanks for this!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9302
Default is "True", so it's opt-in.
Also fixed a bug in accountPreferences.js where changing notification sound was throwing an error instead of playing the preview.