Conversation
ggazzo
requested changes
Jan 3, 2018
| @@ -0,0 +1,11 @@ | |||
| /* globals isFirefox */ | |||
|
|
|||
Member
There was a problem hiding this comment.
const baseUrl = isFirefox ? () => window.location.href.replace(window.location.hash, '') : () => ""
Template.icon.helpers({ baseUrl })
Contributor
Author
There was a problem hiding this comment.
So the isFirefox check run only one time.
Member
There was a problem hiding this comment.
The if will run only one time, but replace (much heavy) will continue running every time.
I don't see much performance improvement for such non readable code.
Contributor
Author
There was a problem hiding this comment.
That function will run over 50 times on every route change, thats why we shouldn't check if is firefox every time.
ggazzo
approved these changes
Jan 3, 2018
This was referenced Jul 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #7980
Closes #9179