Fix: Unneeded warning in payload of REST API calls#9240
Merged
Conversation
graywolf336
previously requested changes
Dec 26, 2017
Contributor
graywolf336
left a comment
graywolf336
left a comment
There was a problem hiding this comment.
Looks good, I would think we should make it so it only is sent when the node environment isn't production.
rodrigok
force-pushed
the
hotfix/9037
branch
from
734b337 to
a4f0fd3
Compare
Member
Author
|
@graywolf336 Why only in development env? It's a real production warning right? |
Member
|
if the size of the warning content is a problem, it could be shorter with a link to the full explanation |
sampaiodiego
approved these changes
Dec 26, 2017
rodrigok
dismissed
graywolf336’s stale review
It's a production warning, I don't think we should show it only in development
rodrigok
added a commit
that referenced
this pull request
Dec 26, 2017
Fix: Unneeded warning in payload of REST API calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9037
Only return the warning when calling routes starting with
channel(s)orgroup(s)and the return contains the room info.