Fix: Message action quick buttons drops if "new message" divider is being shown#9138
Merged
Fix: Message action quick buttons drops if "new message" divider is being shown#9138
Conversation
karlprieb
previously requested changes
Dec 14, 2017
Contributor
karlprieb
left a comment
karlprieb
left a comment
There was a problem hiding this comment.
This "fix" increase the size of the message to put the new message line. We must keep the new messages "inside" the message to not change the message height.
ggazzo
approved these changes
Dec 14, 2017
rodrigok
dismissed
karlprieb’s stale review
Issue created to fix the message height
rodrigok
added a commit
that referenced
this pull request
Dec 15, 2017
Fix: Message action quick buttons drops if "new message" divider is being shown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9129