[FIX] Formal pronouns and some small mistakes in German texts#9067
Merged
rodrigok merged 2 commits intoRocketChat:developfrom Feb 14, 2018
Merged
[FIX] Formal pronouns and some small mistakes in German texts#9067rodrigok merged 2 commits intoRocketChat:developfrom
rodrigok merged 2 commits intoRocketChat:developfrom
Conversation
rodrigok
approved these changes
Jan 20, 2018
Member
|
@AmShaegar13 could you fix he conflicts? |
AmShaegar13
force-pushed
the
fix-german-formal-pronouns
branch
from
00306f7 to
4cd0307
Compare
Contributor
Author
|
@rodrigok fixed. Didn't know this one was still open. |
AmShaegar13
force-pushed
the
fix-german-formal-pronouns
branch
from
4cd0307 to
09ec9ec
Compare
Contributor
Author
|
@rodrigok could you please merge? I just rebased again but I would like to not fix merge conflicts again. |
rodrigok
changed the title
rodrigok
added a commit
that referenced
this pull request
Feb 14, 2018
[FIX] Formal pronouns and some small mistakes in German texts
Contributor
|
@rodrigok I liked the informal german - but adding a second language file for german would mess things up due to higher maintenance, right? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
I fixed mostly formal German pronouns. See http://germanforenglishspeakers.com/pronouns/personal-possessive-pronouns/