[FIX] Link for channels are not rendering correctly#8985
Merged
Conversation
gdelavald
reviewed
Dec 1, 2017
Contributor
gdelavald
left a comment
gdelavald
left a comment
There was a problem hiding this comment.
Any change needed on the npm-shrinkwrap and package-lock here?
gdelavald
reviewed
Dec 1, 2017
| 'hello #general, how are you?' | ||
| ].forEach(text => { | ||
| it(`should return "${ JSON.stringify(result) }" from "${ text }"`, () => { | ||
| console.log('result', mention.getChannelMentions(text)); |
Contributor
There was a problem hiding this comment.
Did you check if this console.log breaks any test?
Contributor
Author
There was a problem hiding this comment.
It doesn't break, but I'll remove.
gdelavald
approved these changes
Dec 1, 2017
rodrigok
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #8954