[FIX] Xenforo [BD]API for 'user.user_id; instead of 'id'#8968
Merged
rodrigok merged 3 commits intoRocketChat:developfrom Dec 4, 2017
Merged
[FIX] Xenforo [BD]API for 'user.user_id; instead of 'id'#8968rodrigok merged 3 commits intoRocketChat:developfrom
rodrigok merged 3 commits intoRocketChat:developfrom
Conversation
For users of XenForo forums using [BD]API plugin for Custom OAuth services, this change will ensure the proper arguments are passed to complete the authentication process. This was provided by user HallyNoona on XenForo community threads at https://xenforo.com/community/threads/bd-api.48900/page-19
|
|
graywolf336
suggested changes
Nov 29, 2017
Contributor
graywolf336
left a comment
graywolf336
left a comment
There was a problem hiding this comment.
Thanks for making these changes, as a former user of Xenforo and [BD]API it is exciting to see this. Do you mind fixing the code linting so that it's the same as the rest of the project? Thanks again!
Contributor
Author
|
Should be good to go now. Thanks for your patience as I learn how to use Github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For users of XenForo forums using [BD]API plugin for Custom OAuth services, this change will ensure the proper arguments are passed to complete the authentication process. This was provided by user HallyNoona on XenForo community threads at https://xenforo.com/community/threads/bd-api.48900/page-19