[FIX] Long room announcement cut off#8907
Merged
Conversation
sampaiodiego
requested changes
Nov 21, 2017
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
For long texts (not only a long word) the ellipsis still does not show and there is no hint/tooltip to see the whole announcement
Contributor
Author
|
@sampaiodiego thanks for your review :) I fixed, take a look:
|
sampaiodiego
approved these changes
Nov 21, 2017
ggazzo
approved these changes
Nov 21, 2017
Contributor
|
But this won't work on mobile, right? |
Contributor
Author
|
@soundstorm No, do you have a suggestion on how this should work on mobile? |
Contributor
|
@karlprieb could be an ontouch event with a popup, so title will show up on desktop and popup on mobile (and touch enabled desktops). |
Member
|
@soundstorm Thanks by the suggestion, I'll merge this PR and we can improve it for mobile before the final release, is that ok @karlprieb ? |
rodrigok
changed the title
Contributor
Author
|
Sure 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #8888