[FIX] Cannot edit or delete custom sounds#8889
Merged
rodrigok merged 2 commits intoRocketChat:developfrom Dec 4, 2017
Merged
Conversation
karlprieb
suggested changes
Nov 17, 2017
| this.autorun(() => { | ||
| const data = Template.currentData(); | ||
| if (data.clear != null) { | ||
| if (data != null && data.clear != null) { |
Contributor
There was a problem hiding this comment.
I think you can change that to if (data && data.clear !== null) :)
Contributor
Author
There was a problem hiding this comment.
Sure, thank you for your comment.
| const data = Template.currentData(); | ||
| const sound = this.sound.get(); | ||
| if (sound.name != null) { | ||
| if (sound != null && sound.name != null) { |
Contributor
Author
There was a problem hiding this comment.
OK.
By the way, i just let it the same with the emojiInfo.js in the beginning
ccfang
commented
Nov 20, 2017
Contributor
Author
ccfang
left a comment
ccfang
left a comment
There was a problem hiding this comment.
Update if statement
| this.autorun(() => { | ||
| const data = Template.currentData(); | ||
| if (data.clear != null) { | ||
| if (data != null && data.clear != null) { |
Contributor
Author
There was a problem hiding this comment.
Sure, thank you for your comment.
| const data = Template.currentData(); | ||
| const sound = this.sound.get(); | ||
| if (sound.name != null) { | ||
| if (sound != null && sound.name != null) { |
Contributor
Author
There was a problem hiding this comment.
OK.
By the way, i just let it the same with the emojiInfo.js in the beginning
Contributor
|
@karlprieb do you mind reviewing again? |
karlprieb
approved these changes
Dec 1, 2017
rodrigok
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Just a minor bug when i would like to upload custom sound and find no way to delete it.