[FIX] Able to react with invalid emoji#8667
Merged
rodrigok merged 6 commits intoRocketChat:developfrom Mar 15, 2018
Merged
Conversation
|
|
mutdmour
changed the title
graywolf336
approved these changes
Nov 4, 2017
Contributor
graywolf336
left a comment
graywolf336
left a comment
There was a problem hiding this comment.
Thanks for the submission!
graywolf336
suggested changes
Dec 1, 2017
| } | ||
|
|
||
| if (!RocketChat.emoji.list[reaction] && RocketChat.models.EmojiCustom.findByNameOrAlias(reaction).count() === 0) { | ||
| throw new Meteor.Error('error-not-allowed', 'Not allowed', { method: 'setReaction' }); |
Contributor
There was a problem hiding this comment.
I know this is an older pull request, do you mind changing this to be error-invalid-emoji and the text be Invalid emoji provided.?
graywolf336
approved these changes
Feb 6, 2018
rodrigok
changed the title
added 2 commits
February 19, 2018 11:48
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[FIX] For bug fixes
@RocketChat/core
Closes #8336
Added verification to check if emoji is regular or custom