[NEW] Use enter separator rather than comma in highlight preferences + Auto refresh after change highlighted words#8433
Merged
rodrigok merged 7 commits intoRocketChat:developfrom Dec 7, 2017
intwarehq:fix-8377
Merged
[NEW] Use enter separator rather than comma in highlight preferences + Auto refresh after change highlighted words#8433rodrigok merged 7 commits intoRocketChat:developfrom intwarehq:fix-8377
rodrigok merged 7 commits intoRocketChat:developfrom
intwarehq:fix-8377
Conversation
cyclops24
changed the title
Member
|
Can you create a migration to keep old values working? |
Contributor
Author
|
@rodrigok We don't need migration here. Because we store highlights value in DB as an array not string. See below image: /CC: @ggazzo , @karlprieb |
Member
|
@cyclops24 Can you fix the conflict? |
Member
|
Can you fix the lint error? |
rodrigok
approved these changes
Dec 7, 2017
This was referenced Jan 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #8377
Closes #8436
It's an improvement for non-English users as @mnlbox said in #8377. + New auto refresh feature after change highlighted words from account preferences
