[NEW] Unify unread and mentions badge#8361
Merged
engelgabriel merged 1 commit intodevelopfrom Sep 30, 2017
Merged
Conversation
Member
|
don't do that =/ is the number |
Member
|
Why not use what we had before: filled box or transparent background?
|
Member
|
The current way takes far too much space.
We can move to the old way (filled box or transparent background) but this PR is already an improvement. @rodrigok please merge this and we can make another PR with the final version. |
Member
|
This situation is just on the hover. I dont think this "small/confuse" is
better. But...
|
Member
|
@ggazzo you can do the PR for the old "filled box or transparent background" if your are so disappointed 😉 |
engelgabriel
approved these changes
Sep 30, 2017
rodrigok
pushed a commit
that referenced
this pull request
Oct 3, 2017
[NEW] Unify unread and mentions badge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core