Skip to content

[FIX] Fix email on mention#7754

Merged
rodrigok merged 3 commits intodevelopfrom
fix-mentions-email-notification
Sep 5, 2017
Merged

[FIX] Fix email on mention#7754
rodrigok merged 3 commits intodevelopfrom
fix-mentions-email-notification

Conversation

@MartinSchoeler
Copy link
Copy Markdown
Member

@MartinSchoeler MartinSchoeler commented Aug 16, 2017 •
edited
Loading

@RocketChat/core
closes #8027

This fixes a issue when you would receive email notifications for all messages even when only the mentions setting was selected

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7754 August 16, 2017 13:47 Inactive
@MartinSchoeler MartinSchoeler mentioned this pull request Aug 16, 2017
Merged
@sampaiodiego
Copy link
Copy Markdown
Member

sampaiodiego commented Aug 16, 2017

Actually it was this way on purpose to prevent too much emails from being sent, so @all mention was used only for push and desktop notifications. @RocketChat/core thoughts?

@pkgodara
Copy link
Copy Markdown
Contributor

pkgodara commented Aug 17, 2017 •
edited
Loading

After #7639 ,
I think settings under preferences and channel settings are clashing. My preferences setting is Every Mentions/DMs & channel setting to Mention, but still I get email notification for every message.

And further, I'm getting notified for messages that I've posted myself.

@rodrigok
Copy link
Copy Markdown
Member

rodrigok commented Aug 21, 2017

IMO, we should send email on @all mentions, cuz it's mention in anyway. We limite the use o @all to rooms with more than a certain number of members

@pkgodara pkgodara mentioned this pull request Aug 27, 2017
Closed
@engelgabriel
Copy link
Copy Markdown
Member

engelgabriel commented Aug 30, 2017

I agree with @rodrigok

@pkgodara pkgodara mentioned this pull request Sep 3, 2017
Closed
@rodrigok rodrigok added this to the 0.59.0-rc.4 milestone Sep 5, 2017
@rodrigok rodrigok merged commit c25746c into develop Sep 5, 2017
@rodrigok rodrigok deleted the fix-mentions-email-notification branch September 5, 2017 22:47
rodrigok added a commit that referenced this pull request Sep 5, 2017
@rodrigok
Merge pull request #7754 from RocketChat/fix-mentions-email-notification
3439d73 
[FIX] Fix email on mention
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rodrigok rodrigok rodrigok approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.59.0-rc.4

Development

Successfully merging this pull request may close these issues.

"Mentions" email setting send emails even when not mentioned

5 participants

@MartinSchoeler @sampaiodiego @pkgodara @rodrigok @engelgabriel