Skip to content

[NEW] Header Redesign#7750

Merged
ggazzo merged 102 commits intocontextual-bar-redesignfrom
top-bar-redesign
Oct 5, 2017
Merged

[NEW] Header Redesign#7750
ggazzo merged 102 commits intocontextual-bar-redesignfrom
top-bar-redesign

Conversation

@MartinSchoeler
Copy link
Copy Markdown
Member

@MartinSchoeler MartinSchoeler commented Aug 15, 2017

@RocketChat/core

Parts done so far:

  • Direct message title

screen shot 2017-08-15 at 3 48 27 pm

  • Channel Title

screen shot 2017-09-13 at 10 41 09 am

  • Administration and account headers

screen shot 2017-09-13 at 10 41 26 am

More Screenshots... screen shot 2017-09-13 at 10 41 51 am screen shot 2017-09-13 at 10 46 54 am screen shot 2017-09-13 at 10 47 12 am screen shot 2017-09-13 at 10 47 25 am
---

closes #7776
closes #7772
closes #8075

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7750 August 15, 2017 18:57 Inactive
height: 77px;
padding: 20px;

color: var(--color-dark);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't you create a variable for this?


&__toggle-favorite {
color: var(--header-toggle-favorite-star-color);
&.--empty {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this cl;ass don't exist.

};

Template.room.helpers({
avatarUrl() {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're returning an avatar background and not the avatar url, change the name or return only the url :)

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7750 August 15, 2017 19:16 Inactive
@MartinSchoeler MartinSchoeler temporarily deployed to rocket-chat-pr-7750 August 16, 2017 19:22 Inactive
@MartinSchoeler MartinSchoeler temporarily deployed to rocket-chat-pr-7750 August 17, 2017 14:27 Inactive
@MartinSchoeler MartinSchoeler temporarily deployed to rocket-chat-pr-7750 August 17, 2017 16:25 Inactive
@MartinSchoeler MartinSchoeler temporarily deployed to rocket-chat-pr-7750 August 17, 2017 18:46 Inactive
@MartinSchoeler MartinSchoeler temporarily deployed to rocket-chat-pr-7750 August 18, 2017 13:05 Inactive
@MartinSchoeler MartinSchoeler temporarily deployed to rocket-chat-pr-7750 August 18, 2017 14:04 Inactive
@MartinSchoeler MartinSchoeler temporarily deployed to rocket-chat-pr-7750 August 18, 2017 17:21 Inactive
@MartinSchoeler MartinSchoeler temporarily deployed to rocket-chat-pr-7750 August 18, 2017 19:06 Inactive
@MartinSchoeler MartinSchoeler temporarily deployed to rocket-chat-pr-7750 August 18, 2017 19:07 Inactive
skipping due some features that need fixing
@MartinSchoeler MartinSchoeler temporarily deployed to rocket-chat-pr-7750 September 29, 2017 19:42 Inactive
karlprieb and others added 23 commits September 29, 2017 16:44
[NEW] Unify unread and mentions badge
[FIX] remove accountBox from admin menu
Manual push by LingoHub User: Gabriel Engel.
Project: Rocket.Chat

Made with ❤️ by https://lingohub.com
Manual push by LingoHub User: Gabriel Engel.
Project: Rocket.Chat

Made with ❤️ by https://lingohub.com
[FIX] Various LDAP issues & Missing pagination
Manual push by LingoHub User: Rodrigo Nascimento.
Project: Rocket.Chat

Made with ❤️ by https://lingohub.com
Manual push by LingoHub User: Rodrigo Nascimento.
Project: Rocket.Chat

Made with ❤️ by https://lingohub.com
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7750 October 4, 2017 18:40 Inactive
@ggazzo ggazzo merged commit 0dd396c into contextual-bar-redesign Oct 5, 2017
@ggazzo ggazzo deleted the top-bar-redesign branch October 5, 2017 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants