Merged
Conversation
| if ((currentUsername === undefined) && ((user != null ? user.username : undefined) != null)) { | ||
| currentUsername = user.username; | ||
| RoomManager.closeAllRooms(); | ||
| FlowRouter.reload(); |
Contributor
There was a problem hiding this comment.
Is a reload going to preserve / load the page?
Member
Author
There was a problem hiding this comment.
I don't know exactly why this code was there.. I only changed the the "function name" not the functionality.
I think this is done because not all places are reactive to user log in, so it need to reload the current route in order to get everything set up.
geekgonecrazy
approved these changes
Aug 8, 2017
rodrigok
added a commit
that referenced
this pull request
Aug 8, 2017
[FIX] Fix room load on first hit
This was referenced Aug 10, 2017
This was referenced Aug 15, 2017
Closed
|
Is this bug fix ? I have the last version of rocket chat and we still have this bug ... |
|
When is this supposed to be in the official release ? Which version ? |
Contributor
|
it should be in 0.58.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Some times when you first hit on a room URL (like https://demo.rocket.chat/channel/general) the room does not load due some kind of race condition.