[FIX] Wrong email subject when "All Messages" setting enabled#7639
Merged
[FIX] Wrong email subject when "All Messages" setting enabled#7639
Conversation
rodrigok
changed the title
rodrigok
approved these changes
Aug 8, 2017
rodrigok
changed the title
rodrigok
added a commit
that referenced
this pull request
Aug 8, 2017
[FIX] Wrong email subject when "All Messages" setting enabled
Contributor
|
@MartinSchoeler After I merged it in #7342 & modified to https://github.com/RocketChat/Rocket.Chat/pull/7342/files#diff-c2dd35e772b329dfcbed709e79e56805 , for enabling subject editing, email notifications are not being sent for mentions in channels. In DMs, it works fine. User preferences is |
Contributor
|
Now I changed |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
This adds a email title for when you set the
all messagesemail notifications preferences