Add missing parts of one click to direct message#7608
Merged
Conversation
sampaiodiego
changed the title
one click to direct messageone click to direct message
rodrigok
force-pushed
the
improvements/one-click-to-direct-message
branch
from
fc38e45 to
c715816
Compare
sampaiodiego
approved these changes
Jul 31, 2017
|
@rodrigok - this look great now. However, this feature introduced a new bug. If the feature is enabled, and I click on my own username, I get an "Invalid User" error. Slack and HipChat both allow you to message yourself, so if that's easy to enable it does have use-cases (e.g. test how an emoji works). If that's a big deal to change perhaps just suppress the error for now. I'm sure there are other solutions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #7436