[FIX] Sweet-Alert modal popup position on mobile devices#7376
Merged
engelgabriel merged 2 commits intoRocketChat:developfrom Jul 4, 2017
Merged
[FIX] Sweet-Alert modal popup position on mobile devices#7376engelgabriel merged 2 commits intoRocketChat:developfrom
engelgabriel merged 2 commits intoRocketChat:developfrom
Conversation
|
|
karlprieb
approved these changes
Jul 4, 2017
This was referenced Jul 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
The popup modals were offset when view on a mobile device. I believe this had something to do with the side menu. Here's my proposed fix for it.
Before:
After:
