[NEW] Add ref="noopener noreferrer" to Markdown links#7327
Merged
rodrigok merged 1 commit intoRocketChat:developfrom Jun 30, 2017
Merged
[NEW] Add ref="noopener noreferrer" to Markdown links#7327rodrigok merged 1 commit intoRocketChat:developfrom
rodrigok merged 1 commit intoRocketChat:developfrom
Conversation
Links created by autolinker already have these attributes. However, links created via Markdown [title](link) or <link|title> didn't have these.
karlprieb
approved these changes
Jun 25, 2017
Contributor
|
Thank you for your contribution 👍 |
Contributor
Author
|
Thanks for approving! :-) I cannot merge myself, will this be merged by someone according to some process? |
Contributor
|
Yes, probably @rodrigok or @engelgabriel will merge this PR :) |
Contributor
|
Hi, Am I wrong? |
jangmarker
added a commit
to jangmarker/Rocket.Chat
that referenced
this pull request
Aug 3, 2017
Follow-up to RocketChat#7327 fixing the usage of "ref" to "rel" as pointed out by @pitamar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links created by autolinker already have these attributes. However, links created via Markdown title or <link|title> didn't have these.
@RocketChat/core
Links created using Markdown syntax leak channel names because they do not have
ref="noreferrer". Links created by autolinker havenoreferrerandnoopener. Add these two attributes to links created via Markdown.