All committers have signed the CLA.

Follow up question: does the bot role have send-many-messages applied to it by default?

https://github.com/RocketChat/Rocket.Chat/blob/develop/packages/rocketchat-authorization/server/startup.js#L49 merged in #7325

Was a migration created to apply this to existing bots? If not, then it's kind of pointless to use that permission for previous systems and will only apply to new bots.

@graywolf336 No, I didn't add a migration, didn't think of it. I can add this in a follow-up PR, if you like?

@jangmarker That would be great. Mark it as a [FIX] since that supposedly has made it in a release already and should be fixed.

@graywolf336

I might be mistaken here, but I understand the permission+roles system to work as follows:

1. a user has a role
2. a role has permissions

So as long as all bots have the bot role they now automatically have the permission send-many-messages via the bot role.

Is that correct?
In this case, no migration is required, from what I understand.

@jangmarker looks like you're correct. If you modify a permission a migration is needed but looks like if a new one is created no migration is needed: https://github.com/RocketChat/Rocket.Chat/blob/develop/packages/rocketchat-authorization/server/startup.js#L69

Thanks for confirming :-).

Then I think nothing is left for this PR except waiting for it be merged. Thanks for all your help and patience.