[new] global search across channel#7274
[new] global search across channel#7274cyberhck wants to merge 2 commits intoRocketChat:developfrom cyberhck:develop
Conversation
|
|
|
Anything going on with this PR? |
| FlowRouter.goToRoomById(message.rid); | ||
| RocketChat.MessageAction.hideDropDown(); | ||
| return RoomHistoryManager.getSurroundingMessages(message, 50); | ||
| window.setTimeout(() => { |
There was a problem hiding this comment.
Not sure if this is necessary.
There was a problem hiding this comment.
ahh, if the connection isn't very good, it sometimes takes some time to go to other room, and it was giving errors, is there a promise or callback which I can use?
I tried without setTimeout because this feels very dirty, it worked the first time because it was instant, then it stopped working.
|
Hey @cyberhck, thanks for the Pull Request! |
|
@gdelavald I was definitely thinking that. I looked into slack and other chats, there were only global ones, and since I'm poor in designing, I wasn't so sure whee to put the checkbox in :) If you have any suggestions, I'd be more than happy to update. |
|
I think the easier/simpler way would be doing something like this: |
|
Okay, I'll keep add this to my do list for tonight :) thanks for feedback |
|
I've been quite busy lately, I'll give this a go again when I have a little breathing room, or if anyone else wants to take it from here, I'm okay with that, (don't care for the bounty, whoever finishes may take it 🙂 ) |
5 participants
@RocketChat/core
Closes #1615
it's really difficult to explain with screenshots, basically this PR enables global search without breaking existing functionality. One optional parameter is now passed to enable global search.
This is my first time doing meteor, so I will need a review.
If there are any changes you'd like, please let me know and I'll fix it.
Thanks.